RFR: Load balance remembered set scanning [v2]
William Kemper
wkemper at openjdk.org
Mon Aug 1 19:41:47 UTC 2022
On Mon, 1 Aug 2022 18:15:59 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:
>> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.cpp line 155:
>>
>>> 153: // Last group does the remnant of heap, one _smallest_chunk_size at a time.
>>> 154: // Round down.
>>> 155: return _heap->num_regions() / 2;
>>
>> I don't understand this comment. Is this a `TODO` comment? Or should this be `initial_group_size`?
>
> I've rewritten the comment here in an attempt to make the intention more clear.
I get it. I think it would be more clear if this method were called `initial_group_size` as the reduction of subsequent group sizes does not happen in this method.
-------------
PR: https://git.openjdk.org/shenandoah/pull/153
More information about the shenandoah-dev
mailing list