RFR: Fix budgeting assertion [v2]

[Kelvin Nilsen]

On Fri, 12 Aug 2022 23:46:29 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> Might be a good idea to describe at line 97, what `cur_young_garbage` will track as you process regions and build the collection set. Similarly, young_curset etc.
>> 
>> I see three separate outer if/else statements covering respectively the cases of generational/global, generational/not global, and non-generational cases. Would it read more easily and make for more easily maintained code to refactor into 3 separate cset builders called for each of the three cases, if necessary from the top level method (but even better if called from different contexts to specialize early hoisting the check on the type of collection up into the highest caller that has the information, rather than having all of them in one single, somewhat long and somewhat unwieldy method?
>
> Thanks for these suggestions.  Adding a comment and "folding" those two addition operations into one.

Not refactoring the body of method for now, but that can be done at a future time.

-------------

PR: https://git.openjdk.org/shenandoah/pull/156