RFR: 8293007: riscv: failed to build after JDK-8290025 [v2]

[Yadong Wang]

On Mon, 29 Aug 2022 11:14:20 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Yadong Wang has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - fix typo
>>  - fix typo
>
> src/hotspot/cpu/riscv/gc/g1/g1BarrierSetAssembler_riscv.cpp line 161:
> 
>> 159:   __ bind(runtime);
>> 160: 
>> 161:   __ push_call_clobbered_registers();
> 
> So this looks like a bugfix? https://mail.openjdk.org/pipermail/riscv-port-dev/2022-August/000601.html
> 
> The issue and PR should probably reflect that then.

Agree. I have modified issue and PR.

> src/hotspot/cpu/riscv/gc/shared/barrierSetAssembler_riscv.cpp line 224:
> 
>> 222:         // which means there isn't really any need for any fencing for neither
>> 223:         // data nor instruction modification happening concurrently. The
>> 224:         // instruction patching is synchronized with glocal icache_flush() by
> 
> "global"?

Thanks. Fixed.

> src/hotspot/cpu/riscv/gc/shared/barrierSetNMethod_riscv.cpp line 204:
> 
>> 202:     // are read in the opposite order, such that the load of the nmethod guard
>> 203:     // acquires the patching epoch. This way, the guard is guaranteed to block
>> 204:     // entries to the nmethod, util it has safely published the requirement for
> 
> "until"?

Fixed.

-------------

PR: https://git.openjdk.org/jdk/pull/10056