RFR: Generation resizing [v3]

Y. Srinivas Ramakrishna ysr at openjdk.org
Fri Dec 9 01:17:41 UTC 2022


On Thu, 8 Dec 2022 08:03:10 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove vestigial lock, do not enroll periodic task while holding threads_lock
>
> src/hotspot/share/gc/shenandoah/shenandoahMmuTracker.hpp line 44:
> 
>> 42:  * The time spent by GC threads is attributed to the young or old generation.
>> 43:  * The time given to the controller and regulator threads is attributed to the
>> 44:  * global generation. At the end of every collection, the average MMU is inspected.
> 
> average over ...? Average MMU over the most recently ended collection cycle? Or over the cumulative history of the run? Or over all of the collection cycles since the last adjustment of generation sizes? etc.

I see now that it's a decaying average over samples at every 5 second interval. May be elaborate the comment accrdingly.

-------------

PR: https://git.openjdk.org/shenandoah/pull/177


More information about the shenandoah-dev mailing list