RFR: Use CardTable::card_size_in_words rather than hard coded constant [v3]

Y. Srinivas Ramakrishna ysr at openjdk.org
Mon Dec 19 20:49:39 UTC 2022


On Mon, 19 Dec 2022 18:54:12 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Calculation assumed 64 words per card, which does not hold on 32 bit word platforms
>
> William Kemper has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
> 
>   Do not assume cards will have 64 words

src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.hpp line 1033:

> 1031:   //      ShenandoahCardCluster<ShenandoahDirectCardMarkRememberedSet>::CardsPerCluster;
> 1032:   // We can't perform this computation here, because of encapsulation and initialization constraints.  We paste
> 1033:   // the magic number here, and assert that this number matches the intended computation in constructor.

Is the portion of the comment beginning "We paste the maginc number ... etc." not obsolete now, and should there be deleted?

-------------

PR: https://git.openjdk.org/shenandoah/pull/186


More information about the shenandoah-dev mailing list