Integrated: JDK-8298597 : HdrSeq: support for a merge() method
Y. Srinivas Ramakrishna
ysr at openjdk.org
Mon Dec 19 20:59:17 UTC 2022
On Thu, 15 Dec 2022 19:33:36 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
> A merge functionality on stats (distributions) was needed for the remembered set scan that I was using in some companion work. This PR implements a first cut at that, which is sufficient for our first (and only) use case.
>
> Unfortunately, for expediency, I am deferring work on decaying statistics, as a result of which users that want decaying statistics will get NaNs instead (or trigger guarantees).
>
> In the sort term, before I open this draft for review, I'll:
>
> - [x] add tests
> - [x] ensure that if a merge action has been taken on a distribution, then any attempt to access a decayed statistic causes an error
> - [x] open a linked ticket to take care of the decayed statistics
>
> An important goal here was to have an API that would be efficient and correct. The API shape may change when we have considered how to handle decaying statistics.
This pull request has now been integrated.
Changeset: bbd4ef34
Author: Y. Srinivas Ramakrishna <ysr at openjdk.org>
Committer: Kelvin Nilsen <kdnilsen at openjdk.org>
URL: https://git.openjdk.org/shenandoah/commit/bbd4ef345122aeb2277c5f24269bda11846ec6ef
Stats: 180 lines in 5 files changed: 153 ins; 2 del; 25 mod
8298597: HdrSeq: support for a merge() method
Reviewed-by: kdnilsen
-------------
PR: https://git.openjdk.org/shenandoah/pull/184
More information about the shenandoah-dev
mailing list