RFR: Initial sizing refactor [v2]

William Kemper wkemper at openjdk.org
Wed Dec 21 19:17:28 UTC 2022


On Tue, 20 Dec 2022 00:51:43 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Improve assertions and comments
>
> src/hotspot/share/gc/shenandoah/shenandoahGeneration.cpp line 995:
> 
>> 993:   shenandoah_assert_heaplocked_or_safepoint();
>> 994:   #ifdef ASSERT
>> 995:   if (generation_mode() == YOUNG) {
> 
> Why the special treatment of young here and in the next method? Is that the only one where max capacity matters?
> 
> I might have expected an assertion oblivious of youth of a generation, which would simpy check upon an increment or a decrement that the floor and ceiling (min and max) capacities of that generation were being respected, irrespective of whether it was a young or old generation?

I'll fix this.

-------------

PR: https://git.openjdk.org/shenandoah/pull/185


More information about the shenandoah-dev mailing list