RFR: JDK-8297796 GenShen: instrument the remembered set scan [v15]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Wed Dec 28 00:40:15 UTC 2022
On Tue, 27 Dec 2022 23:13:05 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:
>> This would also accelerate the transition to degenerated mode, so we can get ourselves out of the STW pause more quickly.
>
> When a work item is picked up, it should be completed since it can't currently be placed back on the work list. Hence the code change, moving the check to the end of the loop. My expectation had been that this would fix the issue with prompt cancellation causing crashes previously. However, testing revealed that this was still causing crashes, so I left the cancellation commented out with the intention of following up on this in the fullness of time.
>
> I'll leave a comment to that effect as you suggest, and mark it with a TODO so it's easily flagged/found.
Fixed.
-------------
PR: https://git.openjdk.org/shenandoah/pull/176
More information about the shenandoah-dev
mailing list