RFR: JDK-8280503: Use allStatic.hpp instead of allocation.hpp where possible [v2]
Thomas Stuefe
stuefe at openjdk.java.net
Mon Jan 24 06:08:05 UTC 2022
On Mon, 24 Jan 2022 05:54:18 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> > > BTW, I have some scripts for checking how often a header file is included. See https://github.com/iklam/tools/tree/main/headers
> >
> >
> > Does your tool tell you include chokepoints, maybe its just one central include pulling in allocation.hpp?
>
> The whoincludes.tcl script can do that. Unfortunately it tells us that many popular header (such as ostream.hpp that was itself included 976 times) include allocations.hpp.
>
> ```
> src/hotspot$ tclsh whoincludes.tcl allocation.hpp| head -20
> scanning 997 allocation.hpp
> 2 found 976 ostream.hpp
> 3 found 960 exceptions.hpp
> 4 found 938 atomic.hpp
> 5 found 891 memRegion.hpp
> 6 found 877 iterator.hpp
> 7 found 871 arena.hpp
> 8 found 864 mutex.hpp
> 9 found 860 growableArray.hpp
> 10 found 855 mutexLocker.hpp
> 11 found 855 autoRestore.hpp
> 12 found 848 padded.hpp
> 13 found 841 linkedlist.hpp
> 14 found 835 jfrAllocation.hpp
> 15 found 832 resourceHash.hpp
> 16 found 829 gcUtil.hpp
> 17 found 825 threadHeapSampler.hpp
> 18 found 825 thread.hpp
> 19 found 825 filterQueue.hpp
> 20 found 679 symbol.hpp
> ```
That's a useful script. Well, maybe we can break this up a bit more.
BTW, can you send me your configure line for your breaking builds? I'd like to reproduce them locally.
-------------
PR: https://git.openjdk.java.net/jdk/pull/7188
More information about the shenandoah-dev
mailing list