RFR: Load balance remembered set scanning [v2]

[Kelvin Nilsen]

On Wed, 27 Jul 2022 21:07:21 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Respond to reviewer comments
>
> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.cpp line 274:
> 
>> 272: }
>> 273: 
>> 274: ShenandoahRegionChunkIterator::ShenandoahRegionChunkIterator(ShenandoahHeap* heap, size_t worker_count) :
> 
> Can we use [constructor delegation](https://en.wikipedia.org/wiki/C++11#Object_construction_improvement) here to remove some duplicated code? Or could we just have clients always pass in the heap reference? One constructor is missing an assert.

Thanks for this suggestion.  I've removed body of one constructor and replaced with constructor delegation.

> src/hotspot/share/gc/shenandoah/shenandoahScanRemembered.hpp line 1025:
> 
>> 1023: };
>> 1024: 
>> 1025: typedef struct ChunkOfRegion {
> 
> Why `typedef`? Could this just be `struct ShenandoahRegionChunk`?

Ok.  I've eliminated the typedef and replaced everywhere with struct ShenandoahRegionChunk.

-------------

PR: https://git.openjdk.org/shenandoah/pull/153