RFR: Fix fullgc [v2]

Kelvin Nilsen kdnilsen at openjdk.java.net
Sun Jun 12 02:55:37 UTC 2022


On Wed, 8 Jun 2022 22:41:52 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Be more careful about changing affiliation to YOUNG
>>  - Remove affiliation overwrite side effect from make_regular_bypass
>>    
>>    This change makes the code more clear and easier to maintain.
>
> src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp line 1347:
> 
>> 1345:           ShenandoahHeapRegion* r = heap->get_region(c);
>> 1346:           // Consider regions emptied by humongous evacuation to be young
>> 1347:           r->make_regular_bypass(true);
> 
> If we remove the side-effect of `make_regular_bypass`, we would have something like:
> 
> if (r->is_humongous_start() || r->is_humongous_cont()) {
>   r->set_affiliation(YOUNG);
> }

I've implemented and tested a change that removes the change-affiliation side effect of make_regular_bypass.

-------------

PR: https://git.openjdk.org/shenandoah/pull/142


More information about the shenandoah-dev mailing list