RFR: Adaptive heuristic should take reserved memory into account [v2]

William Kemper wkemper at openjdk.org
Tue Jun 28 00:03:24 UTC 2022


On Mon, 27 Jun 2022 22:42:35 GMT, Y. S. Ramakrishna <duke at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Adjust comments to stay with moved code
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp line 248:
> 
>> 246:   //   2. Accumulated penalties from Degenerated and Full GC
>> 247:   size_t allocation_headroom = available;
>> 248:   size_t spike_headroom = capacity / 100 * ShenandoahAllocSpikeFactor;
> 
> Should you move the associated comments at lines 281-324 up here as well. The comment further below now dangles on its own.

Sure, I've moved up the relevant comments.

-------------

PR: https://git.openjdk.org/shenandoah/pull/147


More information about the shenandoah-dev mailing list