RFR: 8286814: Shenandoah: RedefineRunningMethods.java test failed with Loom

Aleksey Shipilev shade at openjdk.java.net
Wed May 18 06:25:59 UTC 2022


On Tue, 17 May 2022 19:02:54 GMT, Zhengyu Gu <zgu at openjdk.org> wrote:

> Please review this patch that fixed failed tests.
> 
> To determine if a barrier is needed for newly allocated `stackChunkOop`, it needs to consider current GC phases, as TAMS and update watermark are specific to corresponding GC phase.
> 
> Test:
> 
> - [x] tier1 with `--enable-preview -XX:+UseShenandoahGC` on Linux x86_64 
> - [x] tier2 with `--enable-preview -XX:+UseShenandoahGC` on Linux x86_64
> - [ ] GHA

Looks fine.

src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 2318:

> 2316:     return false;
> 2317:   }
> 2318:   // Objects allocated after evacuation start are guaranteed in to-space, don't need any barriers

Newline missing between these two, I think.

-------------

Marked as reviewed by shade (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/8757


More information about the shenandoah-dev mailing list