RFR: Do not apply evacuation budgets in non-generational mode

[Kelvin Nilsen]

On Thu, 17 Nov 2022 23:15:28 GMT, William Kemper <wkemper at openjdk.org> wrote:

> CSet selection for non-generational mode was using a value configured on the young generation. In non-generational modes we do not maintain all the attributes of the young generation (instead we maintain the _global_ generation). This caused many cycles in which the maximum CSet was zero (or close to it). This, in turn, caused the collector to run much more frequently (approximately 3x on specjbb) which caused severe performance regression in critical jops.
> 
> I'm not sure why the diff algorithm is struggling so much with these changes. I pulled up the `mode()->is_generational()` out of `compute_evacuation_budgets` and `adjust_evacuation_budgets` into the caller and replaced the check with an assert (re-indenting the code in the method).

Thanks for this fix.  I think I may have introduced the bad code.

-------------

PR: https://git.openjdk.org/shenandoah/pull/171