RFR: Fix assertion error with advance promotion budgeting

Roman Kennke rkennke at openjdk.org
Mon Oct 31 16:47:30 UTC 2022


On Mon, 31 Oct 2022 14:31:49 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

> Round-off errors were resulting in an assertion error.  Budgeting calculations are "complicated" because only regions that are fully empty may be loaned from old-gen to young-gen.  This change recalculates certain values during budgeting adjustments that follow collection set selection rather than endeavoring to make changes to the values computed before collection set selection.  The API is simpler as a result.

Looks ok to me.

-------------

Marked as reviewed by rkennke (Lead).

PR: https://git.openjdk.org/shenandoah/pull/165


More information about the shenandoah-dev mailing list