RFR: 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites [v2]

Xiaolin Zheng xlinzheng at openjdk.org
Wed Sep 28 11:09:43 UTC 2022


On Wed, 28 Sep 2022 09:09:33 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix
>
> src/hotspot/cpu/riscv/assembler_riscv.cpp line 119:
> 
>> 117: }
>> 118: 
>> 119: void Assembler::li(Register Rd, int64_t imm, int32_t &offset) {
> 
> It looks to me that we don't need to introduce another 'li' function here. I think you can mask out the lower 12bits of the address and move the result to register with existing 'mv' function. And keep the lower 12bits in offset at the same time. This could be implemented in your new 'mv' function.

Thanks for the advice, very reasonable. I have changed that (need further testing). Others all done.

-------------

PR: https://git.openjdk.org/jdk/pull/10462


More information about the shenandoah-dev mailing list