RFR: 8294492: RISC-V: Use li instead of patchable movptr at non-patchable callsites [v3]

Xiaolin Zheng xlinzheng at openjdk.org
Wed Sep 28 12:35:34 UTC 2022


On Wed, 28 Sep 2022 11:37:53 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Xiaolin Zheng has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix as to comments
>
> src/hotspot/cpu/riscv/macroAssembler_riscv.hpp line 531:
> 
>> 529:   // mv
>> 530:   void mv(Register Rd, address addr)                  { li(Rd, (int64_t)addr); }
>> 531:   void mv(Register Rd, address addr, int32_t &offset) {
> 
> We should add necessary comment for this function, like:
> "Split address into a lower 12-bit sign-extended offset and the remainder so that the offset could be encoded in jalr or load/store instruction."

done - added.

-------------

PR: https://git.openjdk.org/jdk/pull/10462


More information about the shenandoah-dev mailing list