Integrated: Fix build error on MacOS / Clang 14.0.0
Aleksey Shipilev
shade at openjdk.org
Tue Apr 4 19:12:32 UTC 2023
On Tue, 4 Apr 2023 17:16:14 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
> MacOS / Clang 14.0.0 currently fails with lot of errors like:
>
>
> /Users/shipilev/Work/shipilev-shenandoah/src/hotspot/share/gc/shenandoah/mode/shenandoahGenerationalMode.hpp:55:16: warning: 'is_generational' overrides a member function but is not marked 'override' [-Winconsistent-missing-override]
> virtual bool is_generational() { return true; }
> ^
> /Users/shipilev/Work/shipilev-shenandoah/src/hotspot/share/gc/shenandoah/mode/shenandoahMode.hpp:59:16: note: overridden virtual function is here
> virtual bool is_generational() { return false; }
> ^
>
>
> Remarkably, no other heuristics are affected by this, even though they do not have `override`-s on them. I think the actual cause is that we use `override` once in the `ShenandoahGenerationalMode`, that is enough to flag this class for inconsistencies. So the easiest fix is to drop `override`.
>
> Additional testing:
> - [x] macos-aarch64-server-fastdebug build
This pull request has now been integrated.
Changeset: ab9a3971
Author: Aleksey Shipilev <shade at openjdk.org>
URL: https://git.openjdk.org/shenandoah/commit/ab9a39713fafc2257cc34531fe638e82b7221067
Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
Fix build error on MacOS / Clang 14.0.0
Reviewed-by: wkemper
-------------
PR: https://git.openjdk.org/shenandoah/pull/243
More information about the shenandoah-dev
mailing list