RFR: Fix Zero builds

Aleksey Shipilev shade at openjdk.org
Wed Apr 5 07:58:52 UTC 2023


On Tue, 4 Apr 2023 19:15:17 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> Current Zero builds (including ones in GHA) fail like this:
> 
> 
> In file included from /Users/shipilev/Work/shipilev-shenandoah/src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp:28:
> In file included from /Users/shipilev/Work/shipilev-shenandoah/src/hotspot/share/gc/shenandoah/shenandoahCollectionSet.hpp:30:
> /Users/shipilev/Work/shipilev-shenandoah/src/hotspot/share/gc/shenandoah/shenandoahHeap.hpp:452:17: error: inline function 'ShenandoahHeap::get_young_evac_reserve' is not defined [-Werror,-Wundefined-inline]
>   inline size_t get_young_evac_reserve() const;
>                 ^
> /Users/shipilev/Work/shipilev-shenandoah/src/hotspot/share/gc/shenandoah/heuristics/shenandoahAdaptiveHeuristics.cpp:110:50: note: used here
>       size_t max_young_cset    = (size_t) (heap->get_young_evac_reserve() / ShenandoahEvacWaste);
> 
> 
> This is because with Zero, we don't have the transitive include to `shenandoahHeap.inline.hpp`, yet `shenandoahAdaptiveHeuristics.cpp` uses it. The fix is -- as usual -- to add the explicit include.
> 
> Additional testing:
>   - [x] macosx-aarch64-zero-fastdebug
>   - [x] GHA

GHA builds are fine. (Tests are not, but that's another issue)

-------------

PR Comment: https://git.openjdk.org/shenandoah/pull/244#issuecomment-1497069794


More information about the shenandoah-dev mailing list