RFR: Move affiliation and mode out of ShenandoahGenerationalMode [v2]

[William Kemper]

On Thu, 6 Apr 2023 16:14:38 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix Zero builds
>
> src/hotspot/share/gc/shenandoah/shenandoahOldGeneration.cpp line 185:
> 
>> 183: bool ShenandoahOldGeneration::contains(ShenandoahHeapRegion* region) const {
>> 184:   // TODO: Should this be region->is_old() instead?
>> 185:   return !region->is_young();
> 
> Agree with proposed change.  How could this not be a problem?   Is it used?

We have to be careful with this one because some uses expect to visit regions that are both old _and_ free (or young _and_ free). Maybe we should get rid of this method and be explicit about it?

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/246#discussion_r1160026291