RFR: Cleanups, TODOs, asserts (part 1) [v2]

[Aleksey Shipilev]

On Thu, 6 Apr 2023 16:55:29 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   New assert fires, but instead of fixing it, remove useless live_memory completely
>
> src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp line 900:
> 
>> 898:     } else {
>> 899:       return true;
>> 900:         }
> 
> This looks off.

Yes, this reverts to "weird" upstream state: 
https://builds.shipilev.net/patch-openjdk-shenandoah/src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp.sdiff.html

No reason to have whitespace changes if that is the only change in the hunk.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/245#discussion_r1160047465