RFR: Cleanups, TODOs, asserts (part 1) [v2]

[William Kemper]

On Wed, 5 Apr 2023 16:36:01 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> I have been reading the `openjdk/shenandoah` vs `openjdk/jdk` diff and these are the simple code massages we can do to improve and bullet-proof the code, hopefully without changing the semantics. This would continue with more parts later.
>> 
>> Additional testing:
>>  - [x] macos-aarch64-server-fastdebug (some pre-existing failures)
>
> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   New assert fires, but instead of fixing it, remove useless live_memory completely

src/hotspot/share/gc/shenandoah/shenandoahControlThread.cpp line 284:

> 282:           if (age_period-- == 0) {
> 283:              heap->set_aging_cycle(true);
> 284:             age_period = ShenandoahAgingCyclePeriod - 1;

Indentation looks inconsistent here

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/245#discussion_r1160063953