RFR: Cleanups, TODOs, asserts (part 1) [v5]

[Aleksey Shipilev]

On Mon, 10 Apr 2023 23:17:33 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 15 commits:
>> 
>>  - Merge branch 'master' into upstream-cleanup-1
>>  - Refine TODO
>>  - Remove unnecessary comment
>>  - Fix a little indentation error
>>  - New assert fires, but instead of fixing it, remove useless live_memory completely
>>  - Reverse bad fix
>>  - More fixes
>>  - More work
>>  - More improvements
>>  - More touchups
>>  - ... and 5 more: https://git.openjdk.org/shenandoah/compare/461f0831...c0af0d7e
>
> src/hotspot/share/gc/shenandoah/c2/shenandoahBarrierSetC2.cpp line 1020:
> 
>> 1018:     Node* addp = shift->unique_out();
>> 1019:     for (DUIterator_Last jmin, j = addp->last_outs(jmin); j >= jmin; --j) {
>> 1020:       Node *mem = addp->last_out(j);
> 
> `Node* mem`

Done!

> src/hotspot/share/gc/shenandoah/shenandoahConcurrentMark.cpp line 181:
> 
>> 179:   ShenandoahConcurrentWorkerSession worker_session(worker_id);
>> 180:   ShenandoahObjToScanQueue* q = _queue_set->queue(worker_id);
>> 181:   ShenandoahObjToScanQueue* old = (_old_queue_set == nullptr) ?
> 
> call this `old_q` too like you did above at line 121?

Done.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/245#discussion_r1162421014
PR Review Comment: https://git.openjdk.org/shenandoah/pull/245#discussion_r1162420612