RFR: JDK-8301496: Replace NULL with nullptr in cpu/riscv [v2]

Johan Sjölen jsjolen at openjdk.org
Tue Apr 11 09:42:07 UTC 2023


On Wed, 29 Mar 2023 02:35:15 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fixes
>
> src/hotspot/cpu/riscv/stubGenerator_riscv.cpp line 1836:
> 
>> 1834:     __ bne(t1, scratch_src_klass, L_failed);
>> 1835: 
>> 1836:     // if [src->is_Array() != null] then return -1
> 
> nullptr for code fragment

Hi, I changed all of these to "if X is/isn't null" in the previous instances and in this one. Does that sound OK to you?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12324#discussion_r1162555612


More information about the shenandoah-dev mailing list