RFR: JDK-8301493: Replace NULL with nullptr in cpu/aarch64 [v2]

Johan Sjölen jsjolen at openjdk.org
Tue Apr 11 12:55:28 UTC 2023


On Tue, 21 Mar 2023 20:45:01 GMT, Stuart Monteith <smonteith at openjdk.org> wrote:

>> Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Explicitly cast
>
> src/hotspot/cpu/aarch64/interpreterRT_aarch64.cpp line 270:
> 
>> 268:   virtual void pass_object() {
>> 269:     intptr_t* addr = single_slot_addr();
>> 270:     intptr_t value = *addr == 0 ? nullptr : (intptr_t)addr;
> 
> This doesn't compile - perhaps replace nullptr with zero? Unless casting it is more appropriate.

There's similar code in other patches, I did casting in those.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12321#discussion_r1162770322


More information about the shenandoah-dev mailing list