RFR: Cleanups, TODOs, asserts (part 2)

[Aleksey Shipilev]

On Tue, 11 Apr 2023 17:25:22 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> I have been reading the openjdk/shenandoah vs openjdk/jdk diff and these are the simple code massages we can do to improve and bullet-proof the code, hopefully without changing the semantics. This would continue with more parts later.
>> 
>> Additional testing:
>>  - [ ] macos-aarch64-server-fastdebug (some pre-existing failures)
>>  - [ ] GHA builds
>
> src/hotspot/share/gc/shenandoah/shenandoahMarkingContext.hpp line 63:
> 
>> 61: 
>> 62:   // Simple versions of marking accessors, to be used outside of marking (e.g. no possible concurrent updates)
>> 63:   // TODO: Do these really need to be const?
> 
> It's generally considered good hygiene to `const` read accessors. Any reason you would _not_ want them `const`'d?

I'd like to keep the difference vs upstream at minimum. So my question is, do we need these additions for some build/performance reasons, or this is just a hygienic measure? The hygienic fixes in existing upstream code can be done separately straight in upstream.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/252#discussion_r1163772355