RFR: Cleanups, TODOs, asserts (part 2)

[Aleksey Shipilev]

On Wed, 12 Apr 2023 03:06:32 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> I have been reading the openjdk/shenandoah vs openjdk/jdk diff and these are the simple code massages we can do to improve and bullet-proof the code, hopefully without changing the semantics. This would continue with more parts later.
>> 
>> Additional testing:
>>  - [ ] macos-aarch64-server-fastdebug (some pre-existing failures)
>>  - [ ] GHA builds
>
> src/hotspot/share/gc/shenandoah/shenandoahOldGeneration.hpp line 106:
> 
>> 104: private:
>> 105:   bool entry_coalesce_and_fill();
>> 106:   bool coalesce_and_fill();
> 
> Any reason to leave these private methods here, rather than move them to the `private` section immediately following the (related) private data-members at (new) lines 35-37 above?

Right, moved!

> src/hotspot/share/gc/shenandoah/shenandoahVerifier.hpp line 66:
> 
>> 64: 
>> 65:     // Old objects should be registered and RS cards within *read-only* RS are dirty for all
>> 66:     // interesting pointers.
> 
> I'd generally prefer replacing the vague "interesting" (everywhere) with the more precise "inter-generational" :-)

Done!

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/252#discussion_r1163778479
PR Review Comment: https://git.openjdk.org/shenandoah/pull/252#discussion_r1163779461