RFR: Restore event descriptions immortality [v2]

Aleksey Shipilev shade at openjdk.org
Wed Apr 12 14:59:23 UTC 2023


On Wed, 12 Apr 2023 13:17:59 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Drop GLOBAL from non-generational mode
>>  - Restore GLOBAL
>
> src/hotspot/share/gc/shenandoah/shenandoahUtils.hpp line 50:
> 
>> 48:   switch (generation_type) {                                              \
>> 49:     case GLOBAL:                                                          \
>> 50:       return prefix "" postfix;                                           \
> 
> Suggest reporting GLOBAL here.

Ok, now reporting `GLOBAL` for generational mode. This macro is now also checking the generational mode, so we drop any mention of generation in non-generational mode. This keeps the logs the same as upstream for non-generational mode.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/253#discussion_r1164258662


More information about the shenandoah-dev mailing list