RFR: Cleanups, TODOs, asserts (part 2) [v2]
Y. Srinivas Ramakrishna
ysr at openjdk.org
Wed Apr 12 23:24:24 UTC 2023
On Wed, 12 Apr 2023 19:03:25 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> I have been reading the openjdk/shenandoah vs openjdk/jdk diff and these are the simple code massages we can do to improve and bullet-proof the code, hopefully without changing the semantics. This would continue with more parts later.
>>
>> Additional testing:
>> - [x] macos-aarch64-server-fastdebug (some pre-existing failures)
>> - [x] GHA builds
>
> Aleksey Shipilev has updated the pull request incrementally with three additional commits since the last revision:
>
> - More review comments
> - Move and rename remset verifications
> - Review Ramki
It looks like you have a good plan for how to address these and other remarks. I'll go ahead and mark as reviewed!
🚢
-------------
Marked as reviewed by ysr (Author).
PR Review: https://git.openjdk.org/shenandoah/pull/252#pullrequestreview-1382258443
More information about the shenandoah-dev
mailing list