RFR: Restore event descriptions immortality [v2]
Aleksey Shipilev
shade at openjdk.org
Thu Apr 13 08:31:05 UTC 2023
On Wed, 12 Apr 2023 14:59:19 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:
>> Upstream code has event descriptions as immortal strings for a reason: they are passed inside the logging classes, and so the references to them may outlive the scope of the current method. We have seen logs corruption because of that before, e.g. in hs_err-s `Events` section. This PR restores the immortality of event descriptions, producing const strings with macros.
>>
>> This also stops emitting "(GLOBAL)" for global collections, which I think is what non-generational Shenandoah mode prints. Please tell me if we still need to print "(GLOBAL)" in generational mode.
>>
>> Tangentially, this also improves performance for compilers that choose to initialize the automatic storage for `char msg[1024]`, see https://isocpp.org/files/papers/P2723R0.html.
>>
>> Additional testing:
>> - [x] Eyeballing the GC logs
>
> Aleksey Shipilev has updated the pull request incrementally with two additional commits since the last revision:
>
> - Drop GLOBAL from non-generational mode
> - Restore GLOBAL
Thank you!
-------------
PR Comment: https://git.openjdk.org/shenandoah/pull/253#issuecomment-1506557963
More information about the shenandoah-dev
mailing list