RFR: Add generations to freeset [v5]

Y. Srinivas Ramakrishna ysr at openjdk.org
Thu Apr 13 16:56:18 UTC 2023


On Thu, 13 Apr 2023 16:16:47 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove debug instrumentation
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 48:
> 
>> 46:   size_t _mutator_leftmost, _mutator_rightmost;
>> 47:   size_t _collector_leftmost, _collector_rightmost;
>> 48:   size_t _old_collector_leftmost, _old_collector_rightmost;
> 
> Would suggest encapsulation in an interval struct with left & right for each of the three intervals.
> 
> At that point, it would make sense to talk about whether these intervals can overlap (because of interspersing of the range of indices in a specific subset), and whether there are invariants/properties of the union of the intervals that can be checked as invariants after these sub-intervals are adjusted.

I see that some invariants are checked in `assert_bounds` method. A high-level articulation of those invariants before that method would be useful.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/250#discussion_r1165764664


More information about the shenandoah-dev mailing list