RFR: Add generations to freeset [v5]

[Kelvin Nilsen]

On Thu, 13 Apr 2023 11:05:48 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove debug instrumentation
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 138:
> 
>> 136:         ShenandoahHeapRegion* r = _heap->get_region(c);
>> 137:         assert(r->is_trash() || (r->affiliation() == ShenandoahAffiliation::FREE)
>> 138:                || (r->affiliation() == ShenandoahAffiliation::OLD_GENERATION),
> 
> Now replaceable with `!r->is_affiliated()`, `r->old()`, etc.

replaced throughout.

> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 279:
> 
>> 277:         if (allow_new_region) {
>> 278:           // Then try a free region that is dedicated to GC allocations.
>> 279:           if (req.affiliation() == ShenandoahAffiliation::OLD_GENERATION) {
> 
> Here and later, now replaceable with `req.is_old()`.

done.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/250#discussion_r1170573577
PR Review Comment: https://git.openjdk.org/shenandoah/pull/250#discussion_r1170574017