RFR: Add generations to freeset [v5]

Kelvin Nilsen kdnilsen at openjdk.org
Tue Apr 18 21:28:46 UTC 2023


On Thu, 13 Apr 2023 11:17:29 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove debug instrumentation
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.cpp line 648:
> 
>> 646:       }
>> 647:     }
>> 648:     _old_collector_search_left_to_right = (old_collector_available_in_second_half > old_collector_available_in_first_half);
> 
> So, if there are more regions available in the "left" (first) half, then we search from *right* to left? Is this the intent? We need to drop a comment here why.

I've added a comment.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/250#discussion_r1170585740


More information about the shenandoah-dev mailing list