RFR: Add generations to freeset [v5]

[Kelvin Nilsen]

On Thu, 13 Apr 2023 01:43:30 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Kelvin Nilsen has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove debug instrumentation
>
> src/hotspot/share/gc/shenandoah/shenandoahFreeSet.hpp line 81:
> 
>> 79:   HeapWord* try_allocate_in(ShenandoahHeapRegion* region, ShenandoahAllocRequest& req, bool& in_new_region);
>> 80:   HeapWord* allocate_with_affiliation(ShenandoahAffiliation affiliation, ShenandoahAllocRequest& req, bool& in_new_region);
>> 81:   HeapWord* allocate_old_with_affiliation(ShenandoahAffiliation affiliation, ShenandoahAllocRequest& req, bool& in_new_region);
> 
> Given the ubiquity of names `foo()` and `old_foo()`, would it be correct to assume that the former is always `young`? Is there a reason not to use `young_foo()`? (I reask the question further below in a specific case, but it'd be great to understand the nomenclature here. It would be good to may be clarify in a documentation meta-comment somewhere, if not already done.

I'm adding comments to clarify the distinction between allocate_with_affiliation() and allocate_old_with_affiliation().

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/250#discussion_r1170629840