RFR: Usage tracking cleanup [v2]

[William Kemper]

On Wed, 19 Apr 2023 23:56:10 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> William Kemper has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 12 commits:
>> 
>>  - Track total heap usage in global generation
>>  - Remove unused method: clear_used
>>  - Readability improvements
>>  - Merge branch 'shenandoah-master' into alloc-tracking-cleanup
>>  - Merge branch 'shenandoah-master' into alloc-tracking-cleanup
>>  - Remove invalid assert
>>  - Merge branch 'shenandoah-master' into alloc-tracking-cleanup
>>  - Consolidate usage/allocate/waste accounting
>>  - WIP: Oops - report usage in bytes, not words
>>  - WIP: Initialize new padding field
>>  - ... and 2 more: https://git.openjdk.org/shenandoah/compare/016bf071...99c52914
>
> src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp line 1363:
> 
>> 1361: 
>> 1362:     // In generational mode, global usage should be the sum of young and old. This is also true
>> 1363:     // for non-generational modes except that there are no old regions.
> 
> ... so the first addend (or, augend) in each of the arguments below is 0 in the non-generational case? If so, is that worth asserting, just to be super-paranoid?

Yes - the assertions on 1357-1359 assert that these values are all zero for old generation in the non-generational modes.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/260#discussion_r1172750426