RFR: 8305767: HdrSeq: support for a merge() method

Aleksey Shipilev shade at openjdk.org
Thu Apr 20 17:37:44 UTC 2023


On Fri, 7 Apr 2023 23:03:02 GMT, William Kemper <wkemper at openjdk.org> wrote:

> A merge functionality on stats (distributions) was needed for the remembered set scan that I was using in some companion work. This PR implements a first cut at that, which is sufficient for our first (and only) use case.
> 
> Unfortunately, for expediency, I am deferring work on decaying statistics, as a result of which users that want decaying statistics will get NaNs instead (or trigger guarantees).

I have a general comment about this. It looks to me that the new method is actually bulk-add-er? So it should be e.g.:


class NumberSeq {
...
public 
 virtual void add(NumberSeq& other) { ... } // adds all points from another number sequence 



Also, `clear_this` should probably be handled in a separate method (call).

-------------

PR Review: https://git.openjdk.org/jdk/pull/13395#pullrequestreview-1394476025


More information about the shenandoah-dev mailing list