RFR: Add generations to freeset [v8]

[Kelvin Nilsen]

On Thu, 20 Apr 2023 02:46:53 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Also, it sounds like, in the general case, the assertion check `idx < _max` should apply also to the `probe_` version above? I agree that the other assertion below at line 66 may not apply there.
>
> Also note that the number of lines of code would be 1/3 if we had a set abstraction, with the same implementation you have now, and encapsulated all of this triplicated code into that abstraction, and instantiated it into the three sets. But that refactoring can occur in the future since this would stretch this review and need changes again.

Thanks.  I'm inverting the order of assert and bitmap queries and adding the assert to the probe_ methods.

I agree with future refactoring.  Thanks for the suggestions.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/250#discussion_r1173026742