RFR: Cleanup NumberSeq additions [v2]

Aleksey Shipilev shade at openjdk.org
Thu Apr 27 20:24:22 UTC 2023


On Thu, 27 Apr 2023 16:18:06 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clear the fields
>
> src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.cpp line 167:
> 
>> 165: }
>> 166: 
>> 167: void HdrSeq::clear() {
> 
> Don't the _num, _sum, _maximum, etc. need to be cleared as well? May be extend the tests to check for clearing if not already the case.
> 
> Otherwise looks good; will take a closer look in a bit.

Ah yes, of course. Cleared now.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/268#discussion_r1179627000


More information about the shenandoah-dev mailing list