RFR: Cleanup NumberSeq additions [v2]

Aleksey Shipilev shade at openjdk.org
Fri Apr 28 08:21:00 UTC 2023


On Thu, 27 Apr 2023 20:38:04 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clear the fields
>
> src/hotspot/share/gc/shenandoah/shenandoahNumberSeq.cpp line 124:
> 
>> 122: }
>> 123: 
>> 124: void HdrSeq::add(HdrSeq& other) {
> 
> Can we make `other` be a `const` reference? just to make it clear who is getting added to who.

Yes, added!

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/268#discussion_r1180065890


More information about the shenandoah-dev mailing list