RFR: Cleanup NumberSeq additions [v2]

Aleksey Shipilev shade at openjdk.org
Fri Apr 28 08:21:00 UTC 2023


On Thu, 27 Apr 2023 23:42:06 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Clear the fields
>
> test/hotspot/gtest/gc/shenandoah/test_shenandoahNumberSeq.cpp line 112:
> 
>> 110: }
>> 111: 
>> 112: TEST_VM_F(ShenandoahNumberSeqMergeTest, merge_test) {
> 
> You could add a `clear_test` to this, for completeness, checking that the fields are clear following the call. That was being checked at line 125 in the old test, but you could extend and check some of the other fields, viz, `_sum` etc.

Yup, added a separate test.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/268#discussion_r1180066153


More information about the shenandoah-dev mailing list