RFR: 8313574: GenShen: Completing a global mark should also complete an old mark
Y. Srinivas Ramakrishna
ysr at openjdk.org
Fri Aug 4 19:45:03 UTC 2023
On Fri, 4 Aug 2023 18:17:29 GMT, William Kemper <wkemper at openjdk.org> wrote:
> The mark context is shared, but each generation maintains a separate flag (`ShenandoahGeneration::_is_marking_complete`) to record the status of the mark. The remembered set scan will use the mark bitmap only if the old generation mark is complete. Otherwise, it walks the old regions and requires them to be parseable.
>
> Presently, we make the heap parseable after global marking finishes, but this work can be deferred to the start of an old mark if we had global mark record completion of old marking.
LGTM.
Please add a stack retrace of the failure you'd typically see (and perhaps the failing test) that identified this issue into the associated JBS ticket.
Fix looks good.
-------------
Marked as reviewed by ysr (Committer).
PR Review: https://git.openjdk.org/shenandoah/pull/304#pullrequestreview-1563469340
More information about the shenandoah-dev
mailing list