RFR: 8313574: GenShen: Completing a global mark should also complete an old mark [v3]
Kelvin Nilsen
kdnilsen at openjdk.org
Wed Aug 16 14:11:03 UTC 2023
On Tue, 15 Aug 2023 22:11:20 GMT, William Kemper <wkemper at openjdk.org> wrote:
>> The mark context is shared, but each generation maintains a separate flag (`ShenandoahGeneration::_is_marking_complete`) to record the status of the mark. The remembered set scan will use the mark bitmap only if the old generation mark is complete. Otherwise, it walks the old regions and requires them to be parseable.
>>
>> Presently, we make the heap parseable after global marking finishes, but this work can be deferred to the start of an old mark if we had global mark record completion of old marking.
>
> William Kemper has updated the pull request incrementally with two additional commits since the last revision:
>
> - Cleanup duplicate methods to return number of coalesce and fill candidates
> - Restore assertion about which states old generation is allowed to be in when a global cycle degenerates
Still looks good to me...
-------------
Marked as reviewed by kdnilsen (Committer).
PR Review: https://git.openjdk.org/shenandoah/pull/304#pullrequestreview-1580723336
More information about the shenandoah-dev
mailing list