RFR: 8311843: GenShen: assertion failed "Old generation affiliated regions must be less than capacity" [v2]

[Kelvin Nilsen]

On Fri, 25 Aug 2023 23:59:51 GMT, William Kemper <wkemper at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahFullGC.cpp line 1539:
>> 
>>> 1537:         size_t old_regions_deficit = (old_usage - old_capacity) / ShenandoahHeapRegion::region_size_bytes();
>>> 1538:         heap->generation_sizer()->force_transfer_to_old(old_regions_deficit);
>>> 1539:       }
>> 
>> So here, we may end up violating max/min sizes of young generation.  I'm inclined to allow this if that is required to make the just-completed full gc valid.
>
> We may violate a configured constraint, but the usage accounting should be correct now.

good.  and i assume that the configured constraint violation no longer manifests as a failed assertion.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/311#discussion_r1306238943