RFR: 8311843: GenShen: assertion failed "Old generation affiliated regions must be less than capacity" [v2]

[Kelvin Nilsen]

On Sat, 26 Aug 2023 00:12:28 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> Agree that changing shFreeSet to sole arbiter is probably a separate PR, that might be a good improvement.
>
> Given that full-gc is allowed to violate the min/max constraints on generation sizes, I'm inclined to allow the same here, and revert this to force_transfer_to_old().  If that doesn't work, maybe a comment to explain why.  Because I'm not understanding this entirely.

Specifically, it seems if we ever flip without adjusting capacity, we will end up violating assertions of the form old_gen->usage() <= old_gen->capacity().

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/311#discussion_r1306432510