RFR: JDK-8315279: Factor 'basic_plus_adr' out of PhaseMacroExpand and delete make_load/store [v3]

[Cesar Soares Lucas]

On Thu, 31 Aug 2023 17:02:49 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>>> I expect to see all inputs to be separately initialized.
>> 
>> I'm not sure what you mean by this part. Can you elaborate a little here?
>
> static Node* make(PhaseIterGVN& igvn, Node* base, Node* ptr, Node* offset) {
>     return igvn.register_new_node_with_optimizer(new AddPNode(base, ptr, offset));
>   }
> 
> vs
> 
>   static Node* make(PhaseIterGVN& igvn, Node* base, int offset) {
>     return (offset == 0) ? base : make(igvn, base, base, (Node*) igvn.makecon(offset));
>   }
> 
> 
> IMO latter case adds more confusion than improves readability. Why not  unconditionally call `AddPNode::make(base, base, offset)` instead?

Thanks for clarifying @iwanowww . I think I see your point now. My original intent was to just move these methods out of PhaseMacroExpand and not much else. 

I'm going to do some more refactoring and patch all users of these make methods to just use this single method: `static Node* make(PhaseIterGVN& igvn, Node* base, Node* ptr, Node* offset)`. What do you think?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/15480#discussion_r1312197579