RFR: 8321401: Shenandoah: Each mutator must see FullGC before throwing OOM

Kelvin Nilsen kdnilsen at openjdk.org
Wed Dec 6 15:39:41 UTC 2023


On Wed, 6 Dec 2023 14:13:35 GMT, Kelvin Nilsen <kdnilsen at openjdk.org> wrote:

>> src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp line 885:
>> 
>>> 883:     // This will notify the collector to start a cycle, but will raise
>>> 884:     // an OOME to the mutator if the last Full GCs have not made progress.
>>> 885:     if (result == nullptr && !req.is_lab_alloc() && get_gc_no_progress_count() > ShenandoahNoProgressThreshold) {
>> 
>> Does this render `ShenandoahNoProgressThreshold` a dead option?
>
> Good point.  It is no longer relevant.

I'll remove that option for coherency in this PR.   Still need to resolve the question of too-much-time for OOM, mentioned below.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16985#discussion_r1417523732


More information about the shenandoah-dev mailing list