RFR: JDK-8241503: C2: Share MacroAssembler between mach nodes during code emission [v6]
Vladimir Kozlov
kvn at openjdk.org
Wed Dec 20 20:13:49 UTC 2023
On Mon, 18 Dec 2023 18:16:45 GMT, Cesar Soares Lucas <cslucas at openjdk.org> wrote:
>> It seems odd to me that this substantial and complex patch lacks any justification. As far as I can tell, the decision to make class MacroAssembler very lightweight so that new instances could be created as needed was deliberate. Why change now? Is it performance, or something else?
>
> @theRealAph , @TheRealMDoerr - I just picked a JBS work item that seemed important (P3..) and started working on it. To me the refactoring made a lot of sense as well - why just create thousands of objects if just a few would do.
>
> If this is something that doesn't need to be done, please let me know. It already took substantial effort as you said.
@JohnTortugo please, merge latest JDK. Patch did not apply for RISC-V sources (x_riscv.ad and z_riscv.ad).
-------------
PR Comment: https://git.openjdk.org/jdk/pull/16484#issuecomment-1865069941
More information about the shenandoah-dev
mailing list