RFR: 8321939: [GenShen] ShenandoahOldEvacRatioPercent=100 fails with divide-by-zero [v4]

Y. Srinivas Ramakrishna ysr at openjdk.org
Thu Dec 28 00:49:30 UTC 2023


> The code that used the option ShenandoahOldEvacRatioPercent (SOEP) didn't correctly deal with the extremal setting of 100. Corrected the error and did some light refactoring in the vicinity, getting rid of some dead variables, adding documentation, and assertions. Also modified slightly the documentation of the option.
> 
> **Testing:**
> - [x] GHA
> - [x] code pipeline testing (TestPeriodicGC fails without the unrelated fix in https://github.com/openjdk/shenandoah/pull/372)
> - [x] specjbb with SOEP=default,0,100 to verify that the issue is fixed

Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 12 additional commits since the last revision:

 - Backout e780d3bd33ab217543c78891fa50498001637f85
 - Merge branch 'master' into tenure_budget_8314599
 - Merge branch 'master' into tenure_budget_8314599
 - Merge branch 'should_unload_classes' into tenure_budget_8314599
 - Merge branch 'master' into should_unload_classes
 - JDK-8322150 should_unload_classes should return true only if a metaspace
   oom has been signalled, and other conditions are met.
 - Merge branch 'master' into tenure_budget_8314599
 - Fix a scope issue with a local variable.
 - jcheck trailing white-space.
 - Merge branch 'master' into tenure_budget_8314599
 - ... and 2 more: https://git.openjdk.org/shenandoah/compare/111f9cbd...a290be10

-------------

Changes:
  - all: https://git.openjdk.org/shenandoah/pull/369/files
  - new: https://git.openjdk.org/shenandoah/pull/369/files/67318a30..a290be10

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=shenandoah&pr=369&range=03
 - incr: https://webrevs.openjdk.org/?repo=shenandoah&pr=369&range=02-03

  Stats: 4889 lines in 101 files changed: 4838 ins; 6 del; 45 mod
  Patch: https://git.openjdk.org/shenandoah/pull/369.diff
  Fetch: git fetch https://git.openjdk.org/shenandoah.git pull/369/head:pull/369

PR: https://git.openjdk.org/shenandoah/pull/369


More information about the shenandoah-dev mailing list