RFR: 8321939: [GenShen] ShenandoahOldEvacRatioPercent=100 fails with divide-by-zero [v3]

Y. Srinivas Ramakrishna ysr at openjdk.org
Thu Dec 28 01:15:11 UTC 2023


On Fri, 15 Dec 2023 09:19:46 GMT, Y. Srinivas Ramakrishna <ysr at openjdk.org> wrote:

>> Y. Srinivas Ramakrishna has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains ten additional commits since the last revision:
>> 
>>  - Merge branch 'should_unload_classes' into tenure_budget_8314599
>>  - Merge branch 'master' into should_unload_classes
>>  - JDK-8322150 should_unload_classes should return true only if a metaspace
>>    oom has been signalled, and other conditions are met.
>>  - Merge branch 'master' into tenure_budget_8314599
>>  - Fix a scope issue with a local variable.
>>  - jcheck trailing white-space.
>>  - Merge branch 'master' into tenure_budget_8314599
>>  - Fix another case where divide-by-zero could occur when
>>    ShenandoahOldEvacRatioPercent is set to 100. Some slight refactoring in
>>    the method.
>>  - Fix divide-by-zero when ShenandoahOldEvacRatioPercent==100; minor
>>    refactor & modification of documentation of flag
>
> src/hotspot/share/gc/shenandoah/heuristics/shenandoahHeuristics.cpp line 1:
> 
>> 1: /*
> 
> Please ignore the changes in this file for now. It'll go away once the fix for the linked ticket https://bugs.openjdk.org/browse/JDK-8322150 is committed. This PR is blocked until that ticet's PR is committed.

This was backed out in a subsequent commit, so is not present in the final commit, as promised in previous comment.

-------------

PR Review Comment: https://git.openjdk.org/shenandoah/pull/369#discussion_r1437314114


More information about the shenandoah-dev mailing list