RFR: Enhancements for Shenandoah's generational mode [v5]

William Kemper wkemper at openjdk.org
Tue Feb 14 19:26:19 UTC 2023


On Tue, 14 Feb 2023 11:02:19 GMT, Roman Kennke <rkennke at openjdk.org> wrote:

>> William Kemper has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Add notes for running with JDK17+
>
> README.md line 49:
> 
>> 47: Add this additional flag to an active JVM running Shenandoah:
>> 48: 
>> 49:     $ -Xlog:gc+region=debug:<file name>::filesize=<Target byte size for log rotation>,filecount=<Number of files to keep in rotation>
> 
> I am not convinced that unified logging is the right vehicle for recording visualizer region sampling information.

We originally had a separate argument for configuring the log file, but as we started to add features to control the file's size and rotation it became clear that we were duplicating too much of the functionality already in unified logging - so we  scrapped it.

-------------

PR: https://git.openjdk.org/shenandoah-visualizer/pull/1


More information about the shenandoah-dev mailing list